encourage NixOS configuration, nix-shell and discourage nix-env #514
Conversation
MatthewCroughan
force-pushed
the
mc/discourage-nix-env
branch
from
9941b05
to
4e0e76f
Compare
| &:before { | ||
| content: "$ " | ||
| } |
There was a problem hiding this comment.
The point of having this in a :before is that the dollar sign is not copied when you select the whole block
There was a problem hiding this comment.
The pre-existing css is the strangest I've ever seen. What's up with all the nth-child selectors? Positional as opposed to named css? That's just an awful idea.
So I can't blame Matthew for not restoring this functionality for nix-env. He had to remove the $ for the declarative installation methods, which are more important anyway.
There was a problem hiding this comment.
I know, it's awful. There's no need to stick to that pattern though: adding a shell-commands class outside the hierarchy would be fine.
There was a problem hiding this comment.
I am not familiar with elm enough to accomplish this. If you could make a PR that does it to my fork, I'll merge it and it'll be done. But I think the scope of this PR will then have been increased more than it needs to be.
There was a problem hiding this comment.
No problem! I pushed to your branch directly.
|
An example with a shell file would be nice, but certainly no blocker. |
So that it's not selected when you select the whole code block
|
@ncfavier Having reviewed your changes, it looks great.
|
|
@garbas This looks ready to merge. |
This would close #508
High level changes
nix-envnow has a warning associated with it, which explains that it has side-effects which may require cleanup by the user manually after usage like a traditional package manager.environment.systemPackagesornix-shell -p.Internal changes
FromNixOSandFromNixpkgswithViaNixOS,ViaNixShellandViaNixEnv$before every instance of.terminalinfrontend/src/index.lessbecause I was not easily able to case split on imperative cmds likenix-shell -pand the code for a NixOS configuration. Instead,$has been placed manually into each text field where a command is imperative, such asnix buildfor flakes andnix-shell.divfunction, and would appreciate someone to help with thatWhat it looks like
NixOS Configuration
nix-shell
nix-env